manjaro-system issueshttps://gitlab.manjaro.org/packages/core/manjaro-system/-/issues2024-02-25T23:54:22Zhttps://gitlab.manjaro.org/packages/core/manjaro-system/-/issues/8Wrongly enabling os-prober when its variable is non boolean2024-02-25T23:54:22ZAlberto Salvia NovellaWrongly enabling os-prober when its variable is non boolean[manjaro-update-system.sh](https://gitlab.manjaro.org/packages/core/manjaro-system/-/blob/master/manjaro-update-system.sh#L88) is enabling `os-prober` in any scenario where its variable has a non boolean value.
But in reality the variab...[manjaro-update-system.sh](https://gitlab.manjaro.org/packages/core/manjaro-system/-/blob/master/manjaro-update-system.sh#L88) is enabling `os-prober` in any scenario where its variable has a non boolean value.
But in reality the variable can be something else than a boolean. It can be coded, as in [grub-smart](https://gitlab.com/es20490446e/grub-smart/-/blob/main/root/etc/default/grub-smart/default#L81).
Instead `manjaro-update-system.sh` shall simply check if the variable is not present at all:
```
# enable os-prober if not set
config="/etc/default/grub"
if [[ -f "${config}" ]] && ! grep --quiet "GRUB_DISABLE_OS_PROBER" "${config}"; then
printf "GRUB_DISABLE_OS_PROBER=false\n" >> "${config}"
if ! err="$(update-grub 2>&1)"; then
echo "${err}" >&2
fi
fi
```Philip MüllerPhilip Müller