Skip to content
Snippets Groups Projects
  1. Nov 04, 2019
    • David Edmundson's avatar
      Add KDEClangFormat cmake support · 4a6da365
      David Edmundson authored
      Summary:
      This allows devs to run: "make clang-format" and format all files easily
      using the preset KDE clang format style
      
      This patch adds support so devs can easily test the intended formatting
      now, it doesn't change the code yet.
      
      Doing an initial run to commit everything will happen later.
      
      Test Plan:
      Ran script
      git diff was full of amazingly cleaned code
      
      See D25134
      4a6da365
  2. Oct 31, 2019
  3. Oct 19, 2019
  4. Oct 14, 2019
    • Albert Astals Cid's avatar
      Micro optimizations · 993c96a0
      Albert Astals Cid authored
      Summary:
      Add some const & for things that return const & so there's no need to make a copy
      Add a std::move for a thing that we pass by copy and it's just saved in another variable
      
      Reviewers: zzag
      
      Reviewed By: zzag
      
      Subscribers: zzag, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D24614
      993c96a0
  5. Oct 10, 2019
  6. Oct 07, 2019
  7. Oct 01, 2019
  8. Sep 19, 2019
  9. Sep 17, 2019
  10. Aug 24, 2019
  11. Aug 17, 2019
  12. Aug 16, 2019
  13. Aug 15, 2019
    • Noah Davis's avatar
      Fix width and separator of ToolButtonComplexControl outline w/ dropdown menu · b43e19e3
      Noah Davis authored
      Summary: Apparently, the code to adjust the rectangle when a menu is present is what was causing the problem. Also added an if statement to move the separator with the button when sunken.
      
      Test Plan:
      Old:
      {F7248297, size=full}
      {F7248298, size=full}
      
      New:
      {F7248300, size=full}
      {F7248301, size=full}
      
      Reviewers: #vdg, #breeze, ngraham
      
      Reviewed By: #vdg, #breeze, ngraham
      
      Subscribers: ngraham, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D23169
      b43e19e3
  14. Aug 12, 2019
  15. Aug 06, 2019
  16. Aug 04, 2019
  17. Jul 31, 2019
  18. Jul 30, 2019
  19. Jul 23, 2019
  20. Jul 09, 2019
  21. Jul 05, 2019
    • Hugo Pereira Da Costa's avatar
      Remove unneeded 1 pixel margin around side panels · d6b2a3a3
      Hugo Pereira Da Costa authored
      Summary:
      Remove unneeded 1 pixel margin around side panels, namely QAbstractScrollArea with property _kde_side_panel_view set to true.
      In order to be able to still draw a vertical line on the side of the list, a one pixel margin is kept, on this side only, using SE_FrameContent subelementRect
      The viewport background is kept to QPalette::Base, as for regular lists.
      The logic in polishScrollArea has been adjusted accordingly
      
      Differential Revision: https://phabricator.kde.org/D22138
      d6b2a3a3
  22. Jun 28, 2019
    • Noah Davis's avatar
      Remove qtquickcontrols dir · 49c5b696
      Noah Davis authored
      Summary: @mart said these files are no longer used, so I'm removing them.
      
      Reviewers: #breeze, #plasma, davidedmundson
      
      Reviewed By: #plasma, davidedmundson
      
      Subscribers: apol, davidedmundson, mart, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D21969
      49c5b696
    • Hugo Pereira Da Costa's avatar
      - fixed "missing override" warnings · 62ac0c18
      Hugo Pereira Da Costa authored
      - removed useless "virtual" specifications
      - removed useless destructors
      - cleanup variable initializations
      - moved protected methods as private when possible for better encapsulation
      62ac0c18
  23. Jun 25, 2019
  24. Jun 18, 2019
  25. Jun 07, 2019
    • Sebastian Kügler's avatar
      re-read color palettes when application color changes · 9d6c7c7f
      Sebastian Kügler authored
      Summary:
      Without this patch, changing the application color scheme from system
      settings only affects some widgets. Notably, checkboxes highlighting
      colors stays the old color, leading to a hodge-podge color scheme and
      bad contrast on some items.
      
      The breeze QStyle caches the colors read via KSharedConfig, so it needs
      to re-read the configuration when the application color changes.
      QApplication emits a signal (originating in KGlobalSettings), which we
      can react to.
      
      This fixes the coloring of various widgets in breeze right after color
      changes.
      
      BUG:408416
      FIXED-IN: 5.16
      
      Those I haven't tested, but look quite suspicious (so please re-test):
      CCBUG:382505
      CCBUG:355295
      
      Test Plan:
      1. open kcmshell5 colors
      2. change to a theme with a different highlight color
      3. apply
      * without patch: checkbox in color KCM (and a whole lot of other
        widgets all over the place) don't change colors
      * with patch: colors change as expected
      
      Reviewers: #plasma, broulik, sitter
      
      Reviewed By: #plasma, broulik, sitter
      
      Subscribers: sitter, cfeck, broulik, zzag, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D21646
      9d6c7c7f
    • Sebastian Kügler's avatar
      re-read color palettes when application color changes · 092d4460
      Sebastian Kügler authored
      Summary:
      Without this patch, changing the application color scheme from system
      settings only affects some widgets. Notably, checkboxes highlighting
      colors stays the old color, leading to a hodge-podge color scheme and
      bad contrast on some items.
      
      The breeze QStyle caches the colors read via KSharedConfig, so it needs
      to re-read the configuration when the application color changes.
      QApplication emits a signal (originating in KGlobalSettings), which we
      can react to.
      
      This fixes the coloring of various widgets in breeze right after color
      changes.
      
      BUG:408416
      FIXED-IN: 5.16
      
      Those I haven't tested, but look quite suspicious (so please re-test):
      CCBUG:382505
      CCBUG:355295
      
      Test Plan:
      1. open kcmshell5 colors
      2. change to a theme with a different highlight color
      3. apply
      * without patch: checkbox in color KCM (and a whole lot of other
        widgets all over the place) don't change colors
      * with patch: colors change as expected
      
      Reviewers: #plasma, broulik, sitter
      
      Reviewed By: #plasma, broulik, sitter
      
      Subscribers: sitter, cfeck, broulik, zzag, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D21646
      092d4460
    • l10n daemon script's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · 0698750e
      l10n daemon script authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      0698750e
  26. Jun 06, 2019
    • Nathaniel Graham's avatar
      Set default border value in all places · 133eeece
      Nathaniel Graham authored
      Summary:
      The comment says this should match the default border setting in Breeze. Unfortunately it already doesn't. This patch makes it match the new border size in {D13481}.
      
      Depends on D13481
      
      Reviewers: #breeze, abetts
      
      Reviewed By: abetts
      
      Subscribers: abetts, plasma-devel
      
      Tags: #plasma
      
      Maniphest Tasks: T8707
      
      Differential Revision: https://phabricator.kde.org/D13278
      133eeece
    • Roman Gilg's avatar
      Recommend window border size "None" · e15989fb
      Roman Gilg authored
      Summary:
      Adds a recommendation of border size "None" for the new KWin mechanism, which
      allows window decoration plugins to recommend a size for KWin's auto border
      size mode.
      
      We want our default session with Breeze to have no window borders in order to
      reduce visual clutter, make it look more in line with current design trends
      and have cross platform apps look more native, in particular Kirigami apps.
      
      This is a solution for T8707.
      
      Test Plan:
      Manually with patches to KWin. More testers desirable, needs a fully refreshed
      build of Breeze, otherwise the new property is not part of the compiled shared
      library for some reason.
      
      Reviewers: #plasma, #vdg, ngraham
      
      Reviewed By: #vdg, ngraham
      
      Subscribers: pedrogomes1698, hein, januz, ngraham, davidedmundson, graesslin, abetts, mart, plasma-devel
      
      Tags: #plasma
      
      Maniphest Tasks: T8707
      
      Differential Revision: https://phabricator.kde.org/D13481
      e15989fb