Skip to content
Snippets Groups Projects
Commit 48b2f8dc authored by Eli Schwartz's avatar Eli Schwartz Committed by Bartłomiej Piotrowski
Browse files

makechrootpkg: Fix anti-pattern when checking for enabled features


Don't use error-prone logic e.g.
foo=true; if $foo ...

This completely fails to act as expected when the variable is unset
because of unrelated bugs.

While this merely causes the default behavior to be "false" rather than
"true" in such cases, it is better to fail to enable explicitly
requested behavior (which will be noticed by the user) than to simply
upgrade to this behavior for free (which may not seem to have any
obvious cause).

Signed-off-by: default avatarEli Schwartz <eschwartz@archlinux.org>
parent 3b725b58
No related branches found
No related tags found
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment