[PATCH] I2O: first code cleanup of spare warnings and unused functions
Changes: - Removed unnecessary checking of NULL before calling kfree() - Make some functions static - Changed pr_debug() into osm_debug() - Use i2o_msg_in_to_virt() for getting a pointer to the message frame - Cleaned up some comments - Changed some le32_to_cpu() into readl() where necessary - Make error messages of OSM's look the same - Cleaned up error handling in i2o_block_end_request() - Removed unused error handling of failed messages in Block-OSM, which are not allowed by the I2O spec - Corrected the blocksize detection in i2o_block - Added hrt and lct sysfs-attribute to controller - Call done() function in SCSI-OSM after freeing DMA buffers - Removed unneeded variable for message size calculation in i2o_scsi_queuecommand() - Make some changes to remove sparse warnings - Reordered some functions - Cleaned up controller initialization - Replaced some magic numbers by defines - Removed unnecessary dma_sync_single_for_cpu() call on coherent DMA - Removed some unused fields in i2o_controller and removed some unused functions Signed-off-by:Markus Lidel <Markus.Lidel@shadowconnect.com> Signed-off-by:
Andrew Morton <akpm@osdl.org> Signed-off-by:
Linus Torvalds <torvalds@osdl.org>
Showing
- drivers/message/i2o/device.c 4 additions, 5 deletionsdrivers/message/i2o/device.c
- drivers/message/i2o/driver.c 24 additions, 22 deletionsdrivers/message/i2o/driver.c
- drivers/message/i2o/exec-osm.c 26 additions, 21 deletionsdrivers/message/i2o/exec-osm.c
- drivers/message/i2o/i2o_block.c 71 additions, 140 deletionsdrivers/message/i2o/i2o_block.c
- drivers/message/i2o/i2o_block.h 1 addition, 1 deletiondrivers/message/i2o/i2o_block.h
- drivers/message/i2o/i2o_config.c 114 additions, 4 deletionsdrivers/message/i2o/i2o_config.c
- drivers/message/i2o/i2o_scsi.c 14 additions, 17 deletionsdrivers/message/i2o/i2o_scsi.c
- drivers/message/i2o/iop.c 56 additions, 31 deletionsdrivers/message/i2o/iop.c
- drivers/message/i2o/pci.c 30 additions, 37 deletionsdrivers/message/i2o/pci.c
- include/linux/i2o.h 16 additions, 58 deletionsinclude/linux/i2o.h
Loading
Please register or sign in to comment