Skip to content
Snippets Groups Projects

fix #60 - Kauth Action Timeout

Merged Philip Müller requested to merge scachemaille:issue_60_KauthActionTimeOut into master

Created by: scachemaille

Add maximum timeout for each KauthAction

# REMARKS

it need at least Kauth V5.29.0 I'm not sure if and how to put a constraint in makefile for this.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Created by: Kirek

    Nice, but only kernel, language_packages and mhwd need a big timeout, all other calls should be instant or almost instant (because if not something has really gone wrong), so the default timeout is already okay.

  • Created by: scachemaille

    would you I revert back other action? or change to maybe one minutes? I was thinking that maybe locale needed too. as the locale gen can take some times on a slow computer. And do you know how to constrain the build with KF5 min to 5.29?

  • Created by: Kirek

    Yes, for locale one minute timeout would be fine too. To put a constrain for KF5 5.29, you should modify the cmakelists file in the root, add set(KF5_MIN_VERSION "5.29") and then change change the find_package line like this find_package(KF5 ${KF5_MIN_VERSION} REQUIRED COMPONENTS

  • Created by: scachemaille

    reverted all short action timeout to default. changed timeout for locale module to 1min added the KF5 min version to 5.29.

    Build fine on unstable. and doesn't build on stable with buildpkg because of the KF5 constraint. I tried to install a kernel and it worked as expected. all seems good.

  • Created by: Kirek

    Looks good!

Please register or sign in to reply
Loading