Skip to content
Snippets Groups Projects
  • Robert Beckett's avatar
    78c68e8f
    drm/imx: notify drm core before sending event during crtc disable · 78c68e8f
    Robert Beckett authored
    
    Notify drm core before sending pending events during crtc disable.
    This fixes the first event after disable having an old stale timestamp
    by having drm_crtc_vblank_off update the timestamp to now.
    
    This was seen while debugging weston log message:
    Warning: computed repaint delay is insane: -8212 msec
    
    This occurred due to:
    1. driver starts up
    2. fbcon comes along and restores fbdev, enabling vblank
    3. vblank_disable_fn fires via timer disabling vblank, keeping vblank
    seq number and time set at current value
    (some time later)
    4. weston starts and does a modeset
    5. atomic commit disables crtc while it does the modeset
    6. ipu_crtc_atomic_disable sends vblank with old seq number and time
    
    Fixes: a4744786 ("drm/imx: fix crtc vblank state regression")
    
    Signed-off-by: default avatarRobert Beckett <bob.beckett@collabora.com>
    Reviewed-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
    Signed-off-by: default avatarPhilipp Zabel <p.zabel@pengutronix.de>
    78c68e8f
    History
    drm/imx: notify drm core before sending event during crtc disable
    Robert Beckett authored
    
    Notify drm core before sending pending events during crtc disable.
    This fixes the first event after disable having an old stale timestamp
    by having drm_crtc_vblank_off update the timestamp to now.
    
    This was seen while debugging weston log message:
    Warning: computed repaint delay is insane: -8212 msec
    
    This occurred due to:
    1. driver starts up
    2. fbcon comes along and restores fbdev, enabling vblank
    3. vblank_disable_fn fires via timer disabling vblank, keeping vblank
    seq number and time set at current value
    (some time later)
    4. weston starts and does a modeset
    5. atomic commit disables crtc while it does the modeset
    6. ipu_crtc_atomic_disable sends vblank with old seq number and time
    
    Fixes: a4744786 ("drm/imx: fix crtc vblank state regression")
    
    Signed-off-by: default avatarRobert Beckett <bob.beckett@collabora.com>
    Reviewed-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
    Signed-off-by: default avatarPhilipp Zabel <p.zabel@pengutronix.de>
Code owners
Assign users and groups as approvers for specific file changes. Learn more.