Skip to content
Snippets Groups Projects
Commit 1aa3b3e0 authored by Jia-Ju Bai's avatar Jia-Ju Bai Committed by Jan Kara
Browse files

fs: quota: Replace GFP_ATOMIC with GFP_KERNEL in dquot_init


dquot_init() is never called in atomic context.
This function is only set as a parameter of fs_initcall().

Despite never getting called from atomic context,
dquot_init() calls __get_free_pages() with GFP_ATOMIC,
which waits busily for allocation.
GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL,
to avoid busy waiting and improve the possibility of sucessful allocation.

This is found by a static analysis tool named DCNS written by myself.
And I also manually check it.

Signed-off-by: default avatarJia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: default avatarJan Kara <jack@suse.cz>
parent 54a307ba
No related branches found
No related tags found
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment