efi: Don't use spinlocks for efi vars
All efivars operations are protected by a spinlock which prevents interruptions and preemption. This is too restricted, we just need a lock preventing concurrency. The idea is to use a semaphore of count 1 and to have two ways of locking, depending on the context: - In interrupt context, we call down_trylock(), if it fails we return an error - In normal context, we call down_interruptible() We don't use a mutex here because the mutex_trylock() function must not be called from interrupt context, whereas the down_trylock() can. Signed-off-by:Sylvain Chouleur <sylvain.chouleur@intel.com> Signed-off-by:
Ard Biesheuvel <ard.biesheuvel@linaro.org> Cc: Leif Lindholm <leif.lindholm@linaro.org> Cc: Mark Rutland <mark.rutland@arm.com> Cc: Sylvain Chouleur <sylvain.chouleur@gmail.com> Signed-off-by:
Matt Fleming <matt@codeblueprint.co.uk>
Showing
- drivers/firmware/efi/efi-pstore.c 27 additions, 9 deletionsdrivers/firmware/efi/efi-pstore.c
- drivers/firmware/efi/efivars.c 18 additions, 4 deletionsdrivers/firmware/efi/efivars.c
- drivers/firmware/efi/vars.c 80 additions, 57 deletionsdrivers/firmware/efi/vars.c
- fs/efivarfs/inode.c 4 additions, 1 deletionfs/efivarfs/inode.c
- fs/efivarfs/super.c 7 additions, 2 deletionsfs/efivarfs/super.c
- include/linux/efi.h 3 additions, 3 deletionsinclude/linux/efi.h
Loading
Please register or sign in to comment