kvm: introduce manual dirty log reprotect
There are two problems with KVM_GET_DIRTY_LOG. First, and less important,
it can take kvm->mmu_lock for an extended period of time. Second, its user
can actually see many false positives in some cases. The latter is due
to a benign race like this:
1. KVM_GET_DIRTY_LOG returns a set of dirty pages and write protects
them.
2. The guest modifies the pages, causing them to be marked ditry.
3. Userspace actually copies the pages.
4. KVM_GET_DIRTY_LOG returns those pages as dirty again, even though
they were not written to since (3).
This is especially a problem for large guests, where the time between
(1) and (3) can be substantial. This patch introduces a new
capability which, when enabled, makes KVM_GET_DIRTY_LOG not
write-protect the pages it returns. Instead, userspace has to
explicitly clear the dirty log bits just before using the content
of the page. The new KVM_CLEAR_DIRTY_LOG ioctl can also operate on a
64-page granularity rather than requiring to sync a full memslot;
this way, the mmu_lock is taken for small amounts of time, and
only a small amount of time will pass between write protection
of pages and the sending of their content.
Signed-off-by:
Paolo Bonzini <pbonzini@redhat.com>
Showing
- Documentation/virtual/kvm/api.txt 67 additions, 0 deletionsDocumentation/virtual/kvm/api.txt
- arch/mips/kvm/mips.c 23 additions, 0 deletionsarch/mips/kvm/mips.c
- arch/x86/kvm/x86.c 27 additions, 0 deletionsarch/x86/kvm/x86.c
- include/linux/kvm_host.h 5 additions, 0 deletionsinclude/linux/kvm_host.h
- include/uapi/linux/kvm.h 15 additions, 0 deletionsinclude/uapi/linux/kvm.h
- tools/testing/selftests/kvm/Makefile 2 additions, 0 deletionstools/testing/selftests/kvm/Makefile
- tools/testing/selftests/kvm/clear_dirty_log_test.c 2 additions, 0 deletionstools/testing/selftests/kvm/clear_dirty_log_test.c
- tools/testing/selftests/kvm/dirty_log_test.c 19 additions, 0 deletionstools/testing/selftests/kvm/dirty_log_test.c
- tools/testing/selftests/kvm/include/kvm_util.h 2 additions, 0 deletionstools/testing/selftests/kvm/include/kvm_util.h
- tools/testing/selftests/kvm/lib/kvm_util.c 13 additions, 0 deletionstools/testing/selftests/kvm/lib/kvm_util.c
- virt/kvm/arm/arm.c 16 additions, 0 deletionsvirt/kvm/arm/arm.c
- virt/kvm/kvm_main.c 115 additions, 17 deletionsvirt/kvm/kvm_main.c
Loading
Please register or sign in to comment