modules: Fix module_bug_list list corruption race
With all the recent module loading cleanups, we've minimized the code that sits under module_mutex, fixing various deadlocks and making it possible to do most of the module loading in parallel. However, that whole conversion totally missed the rather obscure code that adds a new module to the list for BUG() handling. That code was doubly obscure because (a) the code itself lives in lib/bugs.c (for dubious reasons) and (b) it gets called from the architecture-specific "module_finalize()" rather than from generic code. Calling it from arch-specific code makes no sense what-so-ever to begin with, and is now actively wrong since that code isn't protected by the module loading lock any more. So this commit moves the "module_bug_{finalize,cleanup}()" calls away from the arch-specific code, and into the generic code - and in the process protects it with the module_mutex so that the list operations are now safe. Future fixups: - move the module list handling code into kernel/module.c where it belongs. - get rid of 'module_bug_list' and just use the regular list of modules (called 'modules' - imagine that) that we already create and maintain for other reasons. Reported-and-tested-by:Thomas Gleixner <tglx@linutronix.de> Cc: Rusty Russell <rusty@rustcorp.com.au> Cc: Adrian Bunk <bunk@kernel.org> Cc: Andrew Morton <akpm@linux-foundation.org> Cc: stable@kernel.org Signed-off-by:
Linus Torvalds <torvalds@linux-foundation.org>
Showing
- arch/avr32/kernel/module.c 1 addition, 2 deletionsarch/avr32/kernel/module.c
- arch/h8300/kernel/module.c 1 addition, 2 deletionsarch/h8300/kernel/module.c
- arch/mn10300/kernel/module.c 1 addition, 2 deletionsarch/mn10300/kernel/module.c
- arch/parisc/kernel/module.c 1 addition, 2 deletionsarch/parisc/kernel/module.c
- arch/powerpc/kernel/module.c 0 additions, 5 deletionsarch/powerpc/kernel/module.c
- arch/s390/kernel/module.c 1 addition, 2 deletionsarch/s390/kernel/module.c
- arch/sh/kernel/module.c 0 additions, 2 deletionsarch/sh/kernel/module.c
- arch/x86/kernel/module.c 1 addition, 2 deletionsarch/x86/kernel/module.c
- include/linux/module.h 2 additions, 3 deletionsinclude/linux/module.h
- kernel/module.c 4 additions, 0 deletionskernel/module.c
- lib/bug.c 2 additions, 4 deletionslib/bug.c
Loading
Please register or sign in to comment