Merge branch 'ethtool-fix-use-of-SPEED_UNKNOWN-constant'
Michael Zhivich says:
====================
ethtool: fix use of SPEED_UNKNOWN constant
This patch series addresses 2 related issues:
1. ethtool_validate_speed() triggers a "signed-unsigned comparison"
warning due to type difference of SPEED_UNKNOWN constant (int)
and argument to ethtool_validate_speed (__u32).
2. some drivers use u16 storage for SPEED_UNKNOWN constant,
resulting in value truncation and thus failure to test against
SPEED_UNKNOWN correctly.
This revised series addresses several feedback comments:
- split up the patch in to series
- do not unnecessarily change drivers that use "int" storage
for speed values
====================
Signed-off-by:
David S. Miller <davem@davemloft.net>
No related branches found
No related tags found
Showing
- drivers/net/ethernet/broadcom/tg3.c 4 additions, 4 deletionsdrivers/net/ethernet/broadcom/tg3.c
- drivers/net/ethernet/broadcom/tg3.h 2 additions, 2 deletionsdrivers/net/ethernet/broadcom/tg3.h
- drivers/net/ethernet/qlogic/qlcnic/qlcnic.h 1 addition, 1 deletiondrivers/net/ethernet/qlogic/qlcnic/qlcnic.h
- include/uapi/linux/ethtool.h 1 addition, 1 deletioninclude/uapi/linux/ethtool.h
Loading
Please register or sign in to comment