DMA-API: Change dma_declare_coherent_memory() CPU address to phys_addr_t
dma_declare_coherent_memory() takes two addresses for a region of memory: a "bus_addr" and a "device_addr". I think the intent is that "bus_addr" is the physical address a *CPU* would use to access the region, and "device_addr" is the bus address the *device* would use to address the region. Rename "bus_addr" to "phys_addr" and change its type to phys_addr_t. Most callers already supply a phys_addr_t for this argument. The others supply a 32-bit integer (a constant, unsigned int, or __u32) and need no change. Use "unsigned long", not phys_addr_t, to hold PFNs. No functional change (this could theoretically fix a truncation in a config with 32-bit dma_addr_t and 64-bit phys_addr_t, but I don't think there are any such cases involving this code). Signed-off-by:Bjorn Helgaas <bhelgaas@google.com> Acked-by:
Arnd Bergmann <arnd@arndb.de> Acked-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org> Acked-by:
James Bottomley <jbottomley@Parallels.com> Acked-by:
Randy Dunlap <rdunlap@infradead.org>
Showing
- Documentation/DMA-API.txt 4 additions, 5 deletionsDocumentation/DMA-API.txt
- drivers/base/dma-coherent.c 5 additions, 5 deletionsdrivers/base/dma-coherent.c
- drivers/base/dma-mapping.c 3 additions, 3 deletionsdrivers/base/dma-mapping.c
- include/asm-generic/dma-coherent.h 5 additions, 8 deletionsinclude/asm-generic/dma-coherent.h
- include/linux/dma-mapping.h 4 additions, 3 deletionsinclude/linux/dma-mapping.h
Loading
Please register or sign in to comment