selftests/bpf: fix incorrect users of create_and_get_cgroup
We have some tests that assume create_and_get_cgroup returns -1 on error which is incorrect (it returns 0 on error). Since fd might be zero in general case, change create_and_get_cgroup to return -1 on error and fix the users that assume 0 on error. Fixes: f269099a ("tools/bpf: add a selftest for bpf_get_current_cgroup_id() helper") Fixes: 7d2c6cfc ("bpf: use --cgroup in test_suite if supplied") v2: - instead of fixing the uses that assume -1 on error, convert the users that assume 0 on error (fd might be zero in general case) Signed-off-by:Stanislav Fomichev <sdf@google.com> Signed-off-by:
Alexei Starovoitov <ast@kernel.org>
Showing
- samples/bpf/test_cgrp2_attach2.c 7 additions, 7 deletionssamples/bpf/test_cgrp2_attach2.c
- samples/bpf/test_current_task_under_cgroup_user.c 1 addition, 1 deletionsamples/bpf/test_current_task_under_cgroup_user.c
- tools/testing/selftests/bpf/cgroup_helpers.c 3 additions, 3 deletionstools/testing/selftests/bpf/cgroup_helpers.c
- tools/testing/selftests/bpf/test_cgroup_storage.c 1 addition, 1 deletiontools/testing/selftests/bpf/test_cgroup_storage.c
- tools/testing/selftests/bpf/test_dev_cgroup.c 1 addition, 1 deletiontools/testing/selftests/bpf/test_dev_cgroup.c
- tools/testing/selftests/bpf/test_netcnt.c 1 addition, 1 deletiontools/testing/selftests/bpf/test_netcnt.c
- tools/testing/selftests/bpf/test_skb_cgroup_id_user.c 1 addition, 1 deletiontools/testing/selftests/bpf/test_skb_cgroup_id_user.c
- tools/testing/selftests/bpf/test_sock.c 1 addition, 1 deletiontools/testing/selftests/bpf/test_sock.c
- tools/testing/selftests/bpf/test_sock_addr.c 1 addition, 1 deletiontools/testing/selftests/bpf/test_sock_addr.c
- tools/testing/selftests/bpf/test_socket_cookie.c 1 addition, 1 deletiontools/testing/selftests/bpf/test_socket_cookie.c
- tools/testing/selftests/bpf/test_tcpbpf_user.c 1 addition, 1 deletiontools/testing/selftests/bpf/test_tcpbpf_user.c
- tools/testing/selftests/bpf/test_tcpnotify_user.c 1 addition, 1 deletiontools/testing/selftests/bpf/test_tcpnotify_user.c
Loading
Please register or sign in to comment