BKL: Explicitly add BKL around get_sb/fill_super
This patch is a preparation necessary to remove the BKL from do_new_mount(). It explicitly adds calls to lock_kernel()/unlock_kernel() around get_sb/fill_super operations for filesystems that still uses the BKL. I've read through all the code formerly covered by the BKL inside do_kern_mount() and have satisfied myself that it doesn't need the BKL any more. do_kern_mount() is already called without the BKL when mounting the rootfs and in nfsctl. do_kern_mount() calls vfs_kern_mount(), which is called from various places without BKL: simple_pin_fs(), nfs_do_clone_mount() through nfs_follow_mountpoint(), afs_mntpt_do_automount() through afs_mntpt_follow_link(). Both later functions are actually the filesystems follow_link inode operation. vfs_kern_mount() is calling the specified get_sb function and lets the filesystem do its job by calling the given fill_super function. Therefore I think it is safe to push down the BKL from the VFS to the low-level filesystems get_sb/fill_super operation. [arnd: do not add the BKL to those file systems that already don't use it elsewhere] Signed-off-by:Jan Blunck <jblunck@infradead.org> Signed-off-by:
Arnd Bergmann <arnd@arndb.de> Cc: Matthew Wilcox <matthew@wil.cx> Cc: Christoph Hellwig <hch@infradead.org>
Showing
- fs/adfs/super.c 7 additions, 1 deletionfs/adfs/super.c
- fs/affs/super.c 8 additions, 1 deletionfs/affs/super.c
- fs/afs/super.c 5 additions, 0 deletionsfs/afs/super.c
- fs/bfs/inode.c 7 additions, 1 deletionfs/bfs/inode.c
- fs/cifs/cifsfs.c 10 additions, 2 deletionsfs/cifs/cifsfs.c
- fs/coda/inode.c 7 additions, 1 deletionfs/coda/inode.c
- fs/ecryptfs/main.c 4 additions, 0 deletionsfs/ecryptfs/main.c
- fs/ext2/super.c 8 additions, 2 deletionsfs/ext2/super.c
- fs/ext3/super.c 8 additions, 1 deletionfs/ext3/super.c
- fs/ext4/super.c 6 additions, 2 deletionsfs/ext4/super.c
- fs/fat/namei_msdos.c 6 additions, 1 deletionfs/fat/namei_msdos.c
- fs/fat/namei_vfat.c 6 additions, 1 deletionfs/fat/namei_vfat.c
- fs/freevxfs/vxfs_super.c 6 additions, 1 deletionfs/freevxfs/vxfs_super.c
- fs/hfs/super.c 7 additions, 1 deletionfs/hfs/super.c
- fs/hpfs/super.c 7 additions, 1 deletionfs/hpfs/super.c
- fs/isofs/inode.c 7 additions, 1 deletionfs/isofs/inode.c
- fs/jffs2/super.c 9 additions, 2 deletionsfs/jffs2/super.c
- fs/jfs/super.c 10 additions, 2 deletionsfs/jfs/super.c
- fs/nilfs2/super.c 7 additions, 1 deletionfs/nilfs2/super.c
- fs/ntfs/super.c 5 additions, 0 deletionsfs/ntfs/super.c
Loading
Please register or sign in to comment