Skip to content
Snippets Groups Projects
Commit e9533ae5 authored by Valentin Rothberg's avatar Valentin Rothberg Committed by Greg Kroah-Hartman
Browse files

checkkconfigsymbols.py: fix sorted output


Commit b1a3f243 ("checkkconfigsymbols.py: make it Git aware")
mistakenly removed to print undefined Kconfig symbols in alphabetical
order.  Furthermore, the script does not print anything anymore when the
entire tree is checked (i.e., when no commit is specified).

This patch restores the sorted output and adds the missing print for the
default case.  Additionally, the file lists are now sorted as well which
(a) makes it easier to read and (b) makes the output deterministic.

Signed-off-by: default avatarValentin Rothberg <valentinrothberg@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent a087146c
No related branches found
No related tags found
No related merge requests found
......@@ -112,14 +112,15 @@ def main():
undefined_b = check_symbols()
# report cases that are present for the commit but not before
for feature in undefined_b:
for feature in sorted(undefined_b):
# feature has not been undefined before
if not feature in undefined_a:
files = undefined_b.get(feature)
files = sorted(undefined_b.get(feature))
print "%s\t%s" % (feature, ", ".join(files))
# check if there are new files that reference the undefined feature
else:
files = undefined_b.get(feature) - undefined_a.get(feature)
files = sorted(undefined_b.get(feature) -
undefined_a.get(feature))
if files:
print "%s\t%s" % (feature, ", ".join(files))
......@@ -129,8 +130,9 @@ def main():
# default to check the entire tree
else:
undefined = check_symbols()
for feature in undefined:
files = undefined.get(feature)
for feature in sorted(undefined):
files = sorted(undefined.get(feature))
print "%s\t%s" % (feature, ", ".join(files))
def execute(cmd):
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment