xfs: don't allow insert-range to shift extents past the maximum offset
Zorro Lang reports that generic/485 blows an assert on a filesystem with 512 byte blocks. The test tries to fallocate a post-eof extent at the maximum file size and calls insert range to shift the extents right by two blocks. On a 512b block filesystem this causes startoff to overflow the 54-bit startoff field, leading to the assert. Therefore, always check the rightmost extent to see if it would overflow prior to invoking the insert range machinery. Reported-by:<zlang@redhat.com> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=200137 Signed-off-by:
Darrick J. Wong <darrick.wong@oracle.com> Reviewed-by:
Allison Henderson <allison.henderson@oracle.com> Reviewed-by:
Christoph Hellwig <hch@lst.de>
Showing
- fs/xfs/libxfs/xfs_bmap.c 26 additions, 0 deletionsfs/xfs/libxfs/xfs_bmap.c
- fs/xfs/libxfs/xfs_bmap.h 2 additions, 0 deletionsfs/xfs/libxfs/xfs_bmap.h
- fs/xfs/libxfs/xfs_format.h 2 additions, 0 deletionsfs/xfs/libxfs/xfs_format.h
- fs/xfs/xfs_bmap_util.c 4 additions, 0 deletionsfs/xfs/xfs_bmap_util.c
Loading
Please register or sign in to comment