Skip to content
Snippets Groups Projects
  1. Jun 01, 2019
    • Qian Cai's avatar
      drivers/iommu/intel-iommu.c: fix variable 'iommu' set but not used · d3ed71e5
      Qian Cai authored
      Commit cf04eee8 ("iommu/vt-d: Include ACPI devices in iommu=pt")
      added for_each_active_iommu() in iommu_prepare_static_identity_mapping()
      but never used the each element, i.e, "drhd->iommu".
      
      drivers/iommu/intel-iommu.c: In function
      'iommu_prepare_static_identity_mapping':
      drivers/iommu/intel-iommu.c:3037:22: warning: variable 'iommu' set but
      not used [-Wunused-but-set-variable]
       struct intel_iommu *iommu;
      
      Fixed the warning by appending a compiler attribute __maybe_unused for it.
      
      Link: http://lkml.kernel.org/r/20190523013314.2732-1-cai@lca.pw
      
      
      Signed-off-by: default avatarQian Cai <cai@lca.pw>
      Suggested-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      Cc: Joerg Roedel <jroedel@suse.de>
      Cc: David Woodhouse <dwmw2@infradead.org>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      d3ed71e5
    • Masahiro Yamada's avatar
      treewide: fix typos of SPDX-License-Identifier · 8e82fe2a
      Masahiro Yamada authored
      
      Prior to the adoption of SPDX, it was difficult for tools to determine
      the correct license due to incomplete or badly formatted license text.
      The SPDX solves this issue, assuming people can correctly spell
      "SPDX-License-Identifier" although this assumption is broken in some
      places.
      
      Since scripts/spdxcheck.py parses only lines that exactly matches to
      the correct tag, it cannot (should not) detect this kind of error.
      
      If the correct tag is missing, scripts/checkpatch.pl warns like this:
      
       WARNING: Missing or malformed SPDX-License-Identifier tag in line *
      
      So, people should notice it before the patch submission, but in reality
      broken tags sometimes slip in. The checkpatch warning is not useful for
      checking the committed files globally since large number of files still
      have no SPDX tag.
      
      Also, I am not sure about the legal effect when the SPDX tag is broken.
      
      Anyway, these typos are absolutely worth fixing. It is pretty easy to
      find suspicious lines by grep.
      
        $ git grep --not -e SPDX-License-Identifier --and -e SPDX- -- \
          :^LICENSES :^scripts/spdxcheck.py :^*/license-rules.rst
        arch/arm/kernel/bugs.c:// SPDX-Identifier: GPL-2.0
        drivers/phy/st/phy-stm32-usbphyc.c:// SPDX-Licence-Identifier: GPL-2.0
        drivers/pinctrl/sh-pfc/pfc-r8a77980.c:// SPDX-Lincense-Identifier: GPL 2.0
        lib/test_stackinit.c:// SPDX-Licenses: GPLv2
        sound/soc/codecs/max9759.c:// SPDX-Licence-Identifier: GPL-2.0
      
      Signed-off-by: default avatarMasahiro Yamada <yamada.masahiro@socionext.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      8e82fe2a
    • Alex Xu (Hello71)'s avatar
      crypto: ux500 - fix license comment syntax error · 62e139eb
      Alex Xu (Hello71) authored
      
      Causes error: drivers/crypto/ux500/cryp/Makefile:5: *** missing
      separator.  Stop.
      
      Fixes: af873fce ("treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 194")
      Signed-off-by: default avatarAlex Xu (Hello71) <alex_y_xu@yahoo.ca>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      62e139eb
  2. May 31, 2019
    • Pavel Machek's avatar
      leds: avoid flush_work in atomic context · 8c0f693c
      Pavel Machek authored
      
      It turns out that various triggers use led_blink_setup() from atomic
      context, so we can't do a flush_work there. Flush is still needed for
      slow LEDs, but we can move it to sysfs code where it is safe.
      
          WARNING: inconsistent lock state
          5.2.0-rc1 #1 Tainted: G        W
          --------------------------------
          inconsistent {SOFTIRQ-ON-W} -> {IN-SOFTIRQ-W} usage.
          swapper/1/0 [HC0[0]:SC1[1]:HE1:SE0] takes:
          000000006e30541b
          ((work_completion)(&led_cdev->set_brightness_work)){+.?.}, at:
          +__flush_work+0x3b/0x38a
          {SOFTIRQ-ON-W} state was registered at:
            lock_acquire+0x146/0x1a1
           __flush_work+0x5b/0x38a
           flush_work+0xb/0xd
           led_blink_setup+0x1e/0xd3
           led_blink_set+0x3f/0x44
           tpt_trig_timer+0xdb/0x106
           ieee80211_mod_tpt_led_trig+0xed/0x112
      
      Fixes: 0db37915 ("leds: avoid races with workqueue")
      Signed-off-by: default avatarPavel Machek <pavel@ucw.cz>
      Tested-by: default avatarHugh Dickins <hughd@google.com>
      Signed-off-by: default avatarJacek Anaszewski <jacek.anaszewski@gmail.com>
      8c0f693c
  3. May 30, 2019
Loading